Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 0c256c881596
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: a98e5c2a0dcf
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 5, 2012

  1. streams2: Allow 0 as a lowWaterMark value

    @isaacs
    isaacs committed Oct 5, 2012
    Copy the full SHA
    72e9ee1 View commit details
    Browse the repository at this point in the history

  2. writable stream: Correct drain/return logic 

    It was testing the length *before* adding the current chunk, which
is the opposite of correct.

Also, the return value was flipped.
    @isaacs
    isaacs committed Oct 5, 2012
    Copy the full SHA
    a3fade8 View commit details
    Browse the repository at this point in the history

  3. fixup 0 watermark

    @isaacs
    isaacs committed Oct 5, 2012
    Copy the full SHA
    674b498 View commit details
    Browse the repository at this point in the history

  4. test: Correct fs writable stream 2 test

    @isaacs
    isaacs committed Oct 5, 2012
    Copy the full SHA
    a98e5c2 View commit details
    Browse the repository at this point in the history