Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 6a03fce16eaa
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: a30839576c65
Choose a head ref
  • 1 commit
  • 10 files changed
  • 1 contributor

Commits on Jan 3, 2015

  1. build: i18n: add icu config options

    Make "--with-intl=none" the default and add "intl-none" option to
    vcbuild.bat.
    
    If icu data is missing print a warning unless either --download=all or
    --download=icu is set. If set then automatically download, verify (MD5)
    and unpack the ICU data if not already available.
    
    There's a "list" of URLs being used, but right now only the first is
    picked up. The logic works something like this:
    
    * If there is no directory deps/icu,
      * If no zip file (currently icu4c-54_1-src.zip),
        * Download zip file (icu-project.org -> sf.net)
      * Verify the MD5 sum of the zipfile
        * If bad, print error and exit
      * Unpack the zipfile into deps/icu
    * If deps/icu now exists, use it, else fail with help text
    
    Add the configuration option "--with-icu-source=..."
    
    Usage:
      * --with-icu-source=/path/to/my/other/icu
      * --with-icu-source=/path/to/icu54.zip
      * --with-icu-source=/path/to/icu54.tgz
      * --with-icu-source=http://example.com/icu54.tar.bz2
    
    Add the configuration option "--with-icu-locals=...".  Allows choosing
    which locales are used in the "small-icu" case.
    
    Example:
        configure --with-intl=small-icu --with-icu-locales=tlh,grc,nl
    
    (Also note that as of this writing, neither Klingon nor Ancient Greek
    are in upstream CLDR data. Serving suggestion only.)
    
    Don't use hard coded ../../out paths on windows. This was suggested by
    @misterdjules as it causes test failures.  With this fix, "out" is no
    longer created on windows and the following can run properly:
    
        python tools/test.py simple
    
    Reduce space by about 1MB with ICU 54 (over without this patch). Also
    trims a few other source files, but only conditional on the exact ICU
    version used. This is to future-proof - a file that is unneeded now may
    be needed in future ICUs.
    
    Also:
      * Update distclean to remove icu related files
      * Refactor some code into tools/configure.d/nodedownload.py
      * Update docs
      * Add test
    
    PR-URL: #8719
    Fixes: #7676 (comment)
    [trev.norris@gmail.com small change to test's whitespace and logic]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    srl295 authored and trevnorris committed Jan 3, 2015
    2
    Copy the full SHA
    a308395 View commit details
    Browse the repository at this point in the history