Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: d817843d2e0d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 2bedf6efb16d
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on Jul 19, 2013

  1. tools: make check-imports.sh work on bsd-likes

    @bnoordhuis
    bnoordhuis committed Jul 19, 2013
    Copy the full SHA
    2b7d86e View commit details
    Browse the repository at this point in the history

  2. src: add IsFunction() assert to MakeCallback 

    Helps catch bugs early on. Without it, V8 throws the fairly
unhelpful exception "TypeError: undefined is not a function" -
unhelpful because there is no stack trace.
    @bnoordhuis
    bnoordhuis committed Jul 19, 2013
    Copy the full SHA
    db13983 View commit details
    Browse the repository at this point in the history

  3. src: fix persistent handle lifecycle issue 

    Commit 636ca7c adds an optimization that casts strong Persistent<T>
handles directly to Local<T> handles to avoid the overhead of creating
new HandleScope-rooted Local<T> handles all the time.

One gotcha that I missed is that it's no longer legal to reference the
Local<T> after calling Persistent<T>::Dispose(). This commit addresses
that.
    @bnoordhuis
    bnoordhuis committed Jul 19, 2013
    Copy the full SHA
    2bedf6e View commit details
    Browse the repository at this point in the history