Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: fb6377ebd0ae
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 3c91a7ae10f0
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 7, 2012

  1. readline: don't emit "line" events with a trailing '\n' char 

    Before this commit, readline was inconsistent in whether or not it would emit
"line" events with or without the trailing "\n" included. When "terminal"
mode was true, then there would be no "\n", when it was false, then the "\n"
would be present. However, the trailing "\n" doesn't add much, and most of the
time people just end up stripping it manually.

Part of #4243.
    @TooTallNate
    TooTallNate committed Nov 7, 2012
    Copy the full SHA
    e95e095 View commit details
    Browse the repository at this point in the history

  2. readline: use a "string_decoder" to parse "keypress" events 

    While updating the readline test cases to test both "terimal: false" and
"terminal: true" mode, it turned out that the test case testing utf8 chars
being sent over multiple write() calls was failing. The solution is to use
a string_decoder instance when parsing the "keypress" events.
    @TooTallNate
    TooTallNate committed Nov 7, 2012
    Copy the full SHA
    3c91a7a View commit details
    Browse the repository at this point in the history