small optimizations

mojolicious · Aug 5, 2014 · 7039828 · 7039828
1 parent 1d98e3e
commit 7039828
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/Changes b/Changes
@@ -1,8 +1,9 @@
 
 5.25  2014-08-05
   - Added reduce method to Mojo::Collection.
-  - Fixed escaping bugs in Mojo::DOM::CSS.
+  - Improved sort method in Mojo::Collection to use $a and $b. (batman)
   - Improved documentation browser CSS.
+  - Fixed escaping bugs in Mojo::DOM::CSS.
 
 5.24  2014-08-02
   - Improved url_escape performance slightly.

diff --git a/lib/Mojo/Collection.pm b/lib/Mojo/Collection.pm
@@ -97,12 +97,11 @@ sub sort {
 
   my $caller = caller;
   no strict 'refs';
-  return $self->new(
-    sort {
-      local (*{"$caller\::a"}, *{"$caller\::b"}) = (\$a, \$b);
-      $a->$cb($b);
-    } @$self
-  );
+  my @sorted = sort {
+    local (*{"$caller\::a"}, *{"$caller\::b"}) = (\$a, \$b);
+    $a->$cb($b);
+  } @$self;
+  return $self->new(@sorted);
 }
 
 sub tap { shift->Mojo::Base::tap(@_) }

diff --git a/t/mojo/collection.t b/t/mojo/collection.t
@@ -130,8 +130,7 @@ is_deeply [$collection->sort(sub { uc(shift) cmp uc(shift) })->each],
   [qw(Mojo perl Test)], 'right order';
 $collection = c();
 is_deeply [$collection->sort->each], [], 'no elements';
-is_deeply [$collection->sort(sub { $_[1] cmp $_[0] })->each], [],
-  'no elements';
+is_deeply [$collection->sort(sub { $a cmp $b })->each], [], 'no elements';
 
 # slice
 $collection = c(1, 2, 3, 4, 5, 6, 7, 10, 9, 8);