Fix #289 - Website should work with wsgiref #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were read()ing when there were no bytes expected, which meant we blocked when we shouldn't have.
| @@ -631,7 +631,8 @@ def __init__(self, headers, fp, server_software): | |||
|
|
|||
| """ | |||
| typecheck(headers, Headers, server_software, str) | |||
| self.raw = self._read_raw(server_software, fp) # XXX lazy! | |||
| raw_len = int(headers.get('Content-length', '') or '0') | |||
There was a problem hiding this comment.
Why not just headers.get('Content-length', 0)?
There was a problem hiding this comment.
because it has to be typecasted to int(), and '' needs to be turned into '0'.
chadwhitacre
added a commit
that referenced
this pull request
Apr 1, 2014
Fix #289 - Website should work with wsgiref
Changaco
pushed a commit
that referenced
this pull request
Mar 11, 2016
Fix #289 - Website should work with wsgiref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were read()ing when there were no bytes expected,
which meant we blocked when we shouldn't have.