Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You know the drill ... more small fixes for small issues #303

Merged
merged 5 commits into from Apr 6, 2013
Merged

You know the drill ... more small fixes for small issues #303

merged 5 commits into from Apr 6, 2013

Conversation

Spuds
Copy link
Contributor

@Spuds Spuds commented Apr 5, 2013

No description provided.

Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
Signed-off-by: Spuds <spuds@spudsdesign.com>
norv added a commit that referenced this pull request Apr 6, 2013
You know the drill ... more small fixes for small issues
@norv norv merged commit 8a25be9 into elkarte:master Apr 6, 2013
@norv
Copy link
Contributor

norv commented Apr 6, 2013

@Spuds I'm not sure which is best right now, because it also occurred to me (coffee!) that there is value in parametrizing which col is ordered by. I still think we want a default with order, not without, so perhaps you're right in your proposal and I'm too sleepy to look over atm. Could we consider it simply: at next pass through these functions, we could refactor to choose the most sensible default, in the idea that the client will need the simplest call (so there are defaults), and where it makes sense to vary the col for order, add it to the param, where it doesn't, don't add it. The simplest thing is param = 'DESC' alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants