Skip to content

Commit

Permalink
Removed the warns from the lib file
Browse files Browse the repository at this point in the history
  • Loading branch information
Kartik Thakore committed Sep 6, 2013
1 parent 4b78b32 commit 45750b9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
6 changes: 0 additions & 6 deletions lib/SDLx/Controller.pm
Expand Up @@ -196,13 +196,7 @@ sub _event {
my $stop_handler = $_stop_handler{$ref};
my $event = $_event{$ref};

warn "Event loop runs";
warn SDL::get_error();

SDL::Events::pump_events();

This comment has been minimized.

Copy link
@wchristian

wchristian Mar 13, 2015

Contributor

Does removing pump_events here actually fix anything?

warn "Event pumping event " . Dumper($event);
while ( SDL::Events::poll_event($event) ) {
warn "Event polling event" . Dumper($event);
$stop_handler->( $event, $self ) if $stop_handler;
foreach my $event_handler (@$event_handlers) {
next unless $event_handler;
Expand Down
2 changes: 1 addition & 1 deletion t/ia64_armhf_push_event.t
Expand Up @@ -11,7 +11,7 @@ use SDL::TestTool;
my $videodriver = $ENV{SDL_VIDEODRIVER};
$ENV{SDL_VIDEODRIVER} = 'dummy';

my $dummy = SDLx::App->new( init => SDL_INIT_EVERYTHING );
my $dummy = SDLx::App->new( init => SDL_INIT_VIDEO );

my $event = SDL::Event->new();

Expand Down
3 changes: 2 additions & 1 deletion t/sdlx_controller_interface.t
Expand Up @@ -9,6 +9,7 @@ use SDLx::Controller::Interface;
use lib 't/lib';
use SDL::TestTool;
use Data::Dumper;
use SDL::Events;

my $videodriver = $ENV{SDL_VIDEODRIVER};
$ENV{SDL_VIDEODRIVER} = 'dummy';
Expand Down Expand Up @@ -79,7 +80,7 @@ my $event_called = 0;
require SDL::Event;
require SDL::Events;
my $eve = SDL::Event->new();

$eve->type(SDL_USEREVENT);

This comment has been minimized.

Copy link
@dod38fr

dod38fr Sep 7, 2013

Member

@kthakore : Does this mean that any application creating event is broken on ia64 and armhf ?

If yes, it may be better to set the event type within the SDL::Event creation.

HTH

This comment has been minimized.

Copy link
@kthakore

kthakore via email Sep 7, 2013

Member

This comment has been minimized.

Copy link
@dod38fr

dod38fr via email Sep 8, 2013

Member
SDL::Events::push_event($eve);
my $counts = [ 0, 0, 0 ];

Expand Down

0 comments on commit 45750b9

Please sign in to comment.