Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8874a317484b
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: bbd56d881db2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Feb 6, 2014

  1. test: don't compute knownGlobals lazily 

    Conditional globals like 'gc' should only be recognized when --expose_gc
is set.  The global.gc feature check works only when done eagerly, else
it lets through a leaked variable called 'gc'.
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed Feb 6, 2014
    Copy the full SHA
    2b6e078 View commit details
    Browse the repository at this point in the history

  2. vm: don't copy Proxy object from parent context 

    Make vm.runInContext() and vm.runInNewContext() stop copying the Proxy
object from the parent context into the new context when --harmony or
--harmony_proxies is in effect because it overwrites the new context's
native Proxy object.

This commit also adds a regression test for Harmony symbols.  They work
okay in the current implementation and the test should ensure it stays
that way.
    @bnoordhuis @indutny
    bnoordhuis authored and indutny committed Feb 6, 2014
    Copy the full SHA
    bbd56d8 View commit details
    Browse the repository at this point in the history