Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for Trunk-4139 #665

Closed
wants to merge 1 commit into from
Closed

Conversation

akshika47
Copy link
Contributor

No description provided.

@wluyima
Copy link
Member

wluyima commented Feb 24, 2014

You need to update the hbm file too, have you run the unit tests to ensure that they are all still passing?

@akshika47
Copy link
Contributor Author

hbb file is already updated. :(

@dkayiwa
Copy link
Member

dkayiwa commented Feb 28, 2014

@akshika47 which commit has the hibernate mapping file updates?

@akshika47
Copy link
Contributor Author

give me one second. I will check and tell. I pushed all the changes.

@akshika47
Copy link
Contributor Author

https://github.com/openmrs/openmrs-core/pull/675/files
I am bit confused now. Isn't this the proper pull request?

@akshika47
Copy link
Contributor Author

@dkayiwa : this is not a proper pull request. must be done with a mistake. Sorry for the inconvenience. For Trunk-4139 I still did not make a pull request. I commented in the ticket because @wluyima would look at that comment and merge my other pull requests made on his other tickets. Any way confusion is over. I have finished two tickets. Hope they are fine. And I made another pull request for Ticket-2873(#669). please review it. Thank you.

@ghost
Copy link

ghost commented Feb 28, 2014

Closing pull request per requester's request.

@ghost ghost closed this Feb 28, 2014
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
…found in session (openmrs#665)

* No location selection should return to the location picker

* Review changes
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants