Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 12 files changed
- 1 contributor
Commits on Mar 8, 2013
-
Make it possible to edit config options in adm_config_report.php
Use CONFIG_TYPE_xxx constants instead of magic strings to define the type of config value to process. Added code for FLOAT type which was previously handled through COMPLEX. Improve handling of INT (and FLOAT) by calling constant_replace(), allowing user to specify a defined constant instead of a numeric value. The 'Username', 'Project Name' and 'Configuration Option' fields in the 'Set Configuration Option' form are preset to the corresponding value from the filter or defaulting to ALL_USERS, ALL_PROJECTS and blank respectively if the filter is not defined or set to '[any]'. This allows easier definition of related config, e.g. for a given project or user. Port of 1.2.x commits - 8890b21 - 8b426cf - 5858a65 Fixes #7586, #15416
-
Fix performance issue on adm_config_report.php
In systems with large numbers of config items in mantis_config_table, the Configuration Report page can take a very long time to load. This behavior is due to each of the 'Delete' buttons being printed with its own form, each one having a security token. The performance bottleneck is actually the serialize/unserialize calls executed while storing/retrieving the token from the PHP session. To avoid this problem, the print_button() and form_security_field() functions have been modified to accept a security token as an optional parameter. This allows the calling page to generate a single token, which is shared by all buttons. Furthermore, print_button() also allows the security token parameter to be 'OFF', which prevents the function from displaying a security field. This is useful for buttons not resulting in modifications (i.e. not requiring CSRF protection). Fixes #13680
-
Support for multi-dimentional arrays in admin_config_set.php
This commit adds support for multi-dimentional arrays, as well as correct handling of commas and '=>' within strings. This is based on work by jspezeski; the original code was modified to align with MantisBT coding guidelines, simplification of the recursive function and fixing a couple of errors in regex. Fixes #13298
-
admin_config_set: Revised process_complex_value() function
The new code features an improved regex, which deals more efficiently with the parsing of multi-dimensional and associative arrays. Regex are defined as static variables for better performance with repeated and recursive calls Known issue: an invalid definition like 'array(array(1,2)=>array(3,4))' is not properly parsed. Fixes #13298
There are no files selected for viewing