Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

New headers and indexing datastream parent object #43

Merged
merged 1 commit into from Jun 3, 2014
Merged

Conversation

escowles
Copy link
Contributor

@escowles escowles commented Jun 3, 2014

  • Supporting new header field for baseURL and new identifier format (always node path, not property path)
  • Indexing parent object of datastreams that are indexed

Fixes https://www.pivotaltracker.com/story/show/72530240

…ways node path, not property path). Indexing parent object of datastreams that are indexed

index( getRepositoryURL() + pid, eventType );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are still using "getRepositoryURL()" for reindexing:
https://github.com/fcrepo4/fcrepo-jms-indexer-pluggable/blob/master/fcrepo-jms-indexer-core/src/main/java/org/fcrepo/indexer/IndexerGroup.java#L300
and
https://github.com/fcrepo4/fcrepo-jms-indexer-pluggable/blob/master/fcrepo-jms-indexer-webapp/src/main/java/org/fcrepo/indexer/webapp/FedoraIndexer.java#L62

That is a little confusing, but a consequence of the reindexing being triggered directly vs. via a repository message.
Thoughts on addressing this issue... post-beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ideal, but I don't think it's unreasonable for the indexer to need to be configured with the repository URL(s) in order to support reindexing. Another option would be to have the REST endpoint take full URL(s) instead of just paths relative to the configured repositoryURL. That would allow maximum flexibility.

With repositories that require auth, I don't think there's any way to get around having to configure the credentials. But we could also take advantage of them and use all of the configured repository URLs as the default reindexing targets.

awoods pushed a commit that referenced this pull request Jun 3, 2014
New headers and indexing datastream parent object
@awoods awoods merged commit 0dcfcb6 into master Jun 3, 2014
@awoods awoods deleted the new-headers branch June 3, 2014 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants