Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark intermediate nodes as pairtree elements #540

Merged
merged 1 commit into from Oct 15, 2014
Merged

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Oct 15, 2014

@@ -124,3 +124,5 @@
- fedora:digest (URI) COPY

[fedora:blanknode] > mix:referenceable mixin

[fedora:pairtree] mixin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it buy us having the intermediate nodes be "fedora:pairtree"?
I thought there was a question of versioning not working on these nodes... does that change if they are fedora:pairtree?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the very least, it would let clients know that they haven't reached the "real" node yet, so they could keep following the child references until they did.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add mix:versionable to fedora:pairtree later, and fix whatever problem @mikedurbin reported. But, before we can do that, we need to do this.

awoods pushed a commit that referenced this pull request Oct 15, 2014
Mark intermediate nodes as pairtree elements
@awoods awoods merged commit c515a0c into master Oct 15, 2014
@awoods awoods deleted the mark-pairtree-objects branch October 15, 2014 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants