Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused vars #382

Closed
wants to merge 17 commits into from
Closed

Unused vars #382

wants to merge 17 commits into from

Conversation

joshuaadickerson
Copy link
Contributor

A bunch of unused globals, vars, etc.

@joshuaadickerson
Move loading of membergroups to a central function
14b1c15 
Cache that
Missing a global
@todo a bunch more refactoring and rewriting for this new function
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Add hooks for post.subs.php
fbfbb14 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Add resizeBBCImages()
db84c70 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Reduce another query
3518c54 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Reduce another query
24512a1 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Extraneous checks
08f03be 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Add caching to getTopicInfo()
74a486a 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
A couple of more queries removed
c5a2928 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Show some consideration for the size of caches
cb6cae0 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Remove unused vars
55e90d6 
findUser() was broken
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Memcached was probably broken
4a842b3 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Someone meant to allow for filtering, now it is there.
88ade57 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Removed the first declaration. I think that was the right move.
7a1256f 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Some unused vars and documentation changes
cc63450 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Remove a whole bunch of unused variables, initialize some variables, …
97132b1 
…and maybe fix some bugs.

Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@norv
Copy link
Contributor

norv commented May 10, 2013

This PR has far too many commits. It's definitely not "unused vars". :)
When you make a new PR, github allows you to look at commits, and at the diff, to see what it will grab. Personally I use that feature to quick double-check, it's really handy for small PRs.

@joshuaadickerson :

  • for cleaning up unused variables and some documentation changes, please lets make a clean PR. (see: canSeeBoard() #384 (comment)). They're good to have, but in this state I won't merge it, and even atomic commits are not entirely atomic. (i.e. memcached)
  • does this PR have anything of relevance, you'd like us to consider, which isn't 'unused vars', and isn't in another PR already? I have difficulties following them all. If yes, please make another with those.

@joshuaadickerson
More functions. It's a good thing. Move stuff from template_header()
12a0001 
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@joshuaadickerson
Needlessly complex. Also, shouldn't str_replace("\r"..) be done on in…
fd3f168 
…put?

Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
@norv
Copy link
Contributor

norv commented Jul 15, 2013

I have cherry-picked a few, thanks.

@norv norv closed this Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuaadickerson @norv