Code cleanup in excel_xml_export.php

dregad · dregad · commit fca6d0333ad1 · 2012-03-09T13:21:37.000+01:00
Removed the specific logic to handle the extended text fields, which is no longer required as the BugData API will automatically retrieve them if needed. This is a leftover from the conversion from old, array-style access to bug data (see 2d5e014). Furthermore, the call to bug_get() was redundant, since the result set from filter_get_bug_rows() already contains BugData objects. Fixes #14017 Also removes a useless line of code accidentally left in there by commit 0542805.
diff --git a/excel_xml_export.php b/excel_xml_export.php
@@ -90,8 +90,6 @@
 
 do {
 	foreach( $result as $t_row ) {
-		$t_bug = null;
-
 		if ( is_blank( $f_export ) || in_array( $t_row->id, $f_bug_arr ) ) {
 			echo excel_get_start_row();
 
@@ -103,14 +101,7 @@
 					echo excel_format_plugin_column_value( $t_column, $t_row );
 				} else {
 					$t_function = 'excel_format_' . $t_column;
-					if ( column_is_extended( $t_column ) ) {
-						if( $t_bug === null ) {
-							$t_bug = bug_get( $t_row->id, /* extended = */ true );
-						}
-						echo $t_function( $t_bug->$t_column );
-					} else {
-						echo $t_function( $t_row );
-					}
+					echo $t_function( $t_row );
 				}
 			}
 
@@ -125,7 +116,6 @@
 	if ( $t_more ) {
 		$t_page_number++;
 		$result = filter_get_bug_rows( $t_page_number, $t_per_page, $t_page_count, $t_bug_count );
-		$t_more !== false;
 	}
 } while ( $t_more );
 
