Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 401cef797df3
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 9299168f2a2e
Choose a head ref
  • 4 commits
  • 12 files changed
  • 2 contributors

Commits on Feb 16, 2013

  1. Revert "Move MakeCallback to JS" 

    This reverts commit 0109a9f.

Also included:  Port all the changes to process._makeCallback into the
C++ version.  Immediate nextTick, etc.

This yields a slight boost in several benchmarks.  V8 is optimizing and
deoptimizing process._makeCallback repeatedly.
    @isaacs
    isaacs committed Feb 16, 2013
    Copy the full SHA
    95ac576 View commit details
    Browse the repository at this point in the history

  2. process: streamlining tick callback logic 

    * Callbacks from spinner now calls its own function, separate from the
  tickCallback logic
* MakeCallback will call a domain specific function if a domain is
  detected
* _tickCallback assumes no domains, until nextTick receives a callback
  with a domain. After that _tickCallback is overridden with the domain
  specific implementation.
* _needTickCallback runs in startup() instead of nextTick (isaacs)
* Fix bug in _fatalException where exit would be called twice (isaacs)
* Process.domain has a default value of null
* Manually track nextTickQueue.length (will be useful later)
* Update tests to reflect internal api changes
    @trevnorris @isaacs
    trevnorris authored and isaacs committed Feb 16, 2013
    10
    Copy the full SHA
    86c0745 View commit details
    Browse the repository at this point in the history

  3. process: allow ticker to cross communicate better 

    Using external memory values allows for quick communication between js
and cc land, so we can check if the js land callback needs to be run.
(this is where I meant that manually tracking nextTickQueue.length would
be helpful)

Also did some minor cleanup of removing the old Tick and
StartTickSpinner functions, and a few unneeded comments.

Conflicts:

	src/node.cc
    @trevnorris @isaacs
    trevnorris authored and isaacs committed Feb 16, 2013
    Copy the full SHA
    ec42000 View commit details
    Browse the repository at this point in the history

  4. test: Bump up debugger timeouts 

    200ms is still short enough for occasional spurious failures.
    @isaacs
    isaacs committed Feb 16, 2013
    Copy the full SHA
    9299168 View commit details
    Browse the repository at this point in the history