Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 06dcfae12acf
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3a0f427f207a
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Nov 17, 2014

  1. Get -v into regression specs to find hangs.

    @headius
    headius committed Nov 17, 2014
    Copy the full SHA
    4610594 View commit details

  2. More attempts to make this pass. Nondeterminism sucks.

    @headius
    headius committed Nov 17, 2014
    Copy the full SHA
    3a0f427 View commit details
Showing with 4 additions and 1 deletion.
  1. +2 −0 rakelib/rspec.rake
  2. +2 −1 spec/regression/GH-1075_fiber_does_not_finalize_properly_spec.rb
2 changes: 2 additions & 0 deletions rakelib/rspec.rake
View file
Original file line number Diff line number Diff line change
@@ -53,6 +53,8 @@ namespace :spec do
end

permute_specs "regression", compile_flags do |t|
t.rspec_opts ||= []
t.rspec_opts << '-f s'
t.pattern = 'spec/regression/**/*_spec.rb'
end

3 changes: 2 additions & 1 deletion spec/regression/GH-1075_fiber_does_not_finalize_properly_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -31,8 +31,9 @@
# Try to force finalizers to run
java.lang.Runtime.runtime.run_finalization

# Spin for a while, hoping to make this pass
# Spin for a while and GC, hoping to make this pass
1000.times do
JRuby.gc
JRuby.runtime.fiber_executor.maximum_pool_size = 1
break if (thread_bean.thread_count - thread_count) < 10
Thread.pass