Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 71cddf03bbc5
Choose a base ref
...
head repository: jruby/jruby
compare: 376560533681
Choose a head ref
  • 5 commits
  • 20 files changed
  • 1 contributor

Commits on Oct 10, 2014

  1. [Truffle] Remove cases using both isModuleMethod and visibility. 

    *  Also add a warning (but cannot detect the default PUBLIC visibility).
    @eregon
    eregon committed Oct 10, 2014
    Copy the full SHA
    f51d47b View commit details
    Browse the repository at this point in the history

  2. [Truffle] Rename isModuleMethod to isModuleFunction. 

    * This is colser to Ruby terminology.
* Also indicates the receiver is likely ignored.
    @eregon
    eregon committed Oct 10, 2014
    Copy the full SHA
    ae1e355 View commit details
    Browse the repository at this point in the history

  3. [Truffle] Kernel.binding should not need self. 

    * Fixes: eval "self", Kernel.binding
    @eregon
    eregon committed Oct 10, 2014
    Copy the full SHA
    630d47b View commit details
    Browse the repository at this point in the history

  4. [Truffle] Remove the last usage of isModuleFunction and needsSelf.

    @eregon
    eregon committed Oct 10, 2014
    Copy the full SHA
    2bd4fe6 View commit details
    Browse the repository at this point in the history

  5. [Truffle] Do not allow module functions to use self as it depends on … 

    …context.

* One can use RubyArguments.getSelf(frame.getArguments()) for extraordinary cases.
* But these tend to never happen, we just need better support for singleton-only methods.
    @eregon
    eregon committed Oct 10, 2014
    Copy the full SHA
    3765605 View commit details
    Browse the repository at this point in the history