Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trunk-4139 #706

Closed
wants to merge 1 commit into from
Closed

Trunk-4139 #706

wants to merge 1 commit into from

Conversation

akshika47
Copy link
Contributor

No description provided.

@akshika47
Copy link
Contributor Author

@dkayiwa here is the new pull

@dkayiwa
Copy link
Member

dkayiwa commented Mar 5, 2014

Can you add a unit test about an order with a scheduled date to save?
Can you also learn to include text in the commit message describing what this is all about?

@akshika47
Copy link
Contributor Author

@dkayiwa : right away. I am working on it :)

@ghost
Copy link

ghost commented Mar 6, 2014

Please use more a descriptive pull request title, similar to that as described for commit messages in https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section "Work on your task".

@akshika47
Copy link
Contributor Author

Yes, I will, Sorry about it, this commit was done a time before. Before
Daniel asked me to do so. I will do in that manner next time for sure.

On Thu, Mar 6, 2014 at 7:19 PM, Michael Downey notifications@github.comwrote:

Please use more a descriptive pull request title, similar to that as
described for commit messages in
https://wiki.openmrs.org/display/docs/Using+Git under step 3 in section
"Work on your task".

Reply to this email directly or view it on GitHubhttps://github.com//pull/706#issuecomment-36888953
.

Akshika Wijesundara
Department of Computer Science & Engineering
University of Moratuwa
Sri Lanka,

@dkayiwa
Copy link
Member

dkayiwa commented Mar 10, 2014

Closing this PR because author opened a new one: #751

@dkayiwa dkayiwa closed this Mar 10, 2014
RandilaP pushed a commit to RandilaP/openmrs-core that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants