Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe have the sort by things in a dropdown? #733

Closed
wants to merge 1 commit into from

Conversation

emanuele45
Copy link
Contributor

Was playing a bit... 馃槆

If you think it may be interesting, there are other places where it would be applicable (i.e. recent something).

Signed-off-by: emanuele <emanuele45@gmail.com>
@StealthWombat
Copy link
Contributor

Yeah have thought of that before, and it's a good solution, especially for small screens. I had thought of doing something like that but wasn't sure how people would react. Couple of points:

1/ Why does it need javascript for the select? Don't most selects run without js?
2/ What happens if js is disabled?
3/ Selects are a bastard to style. It's a PITA getting them looking good in all browsers. Personally, I'd be more inclined to use the standard Superthingy droppys with the existing classes.

@StealthWombat
Copy link
Contributor

Ok, further thinking. How about if this, and the memberlist search stuff, both used a minmax whatsit? Just show an extra line if button is clicked. Click again to hide.

@emanuele45
Copy link
Contributor Author

Re: javascript: yep, it won't work with s disabled.
Re: dropdown: it was easier to code and didn't involve css on my side. 馃槢
Re: further thinking: ...I think the answer is no, but I'm not sure what you are asking... lol

@live627
Copy link
Contributor

live627 commented Jul 25, 2013

Re: further thinking: ...I think the answer is no, but I'm not sure what you are asking... lol

Upshrink

@emanuele45 emanuele45 closed this Aug 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants