Fixes the code to actually test the second parameter, instead of the …

…first one twice (fixes #3526870) Change-Id: I2ade25c5fabd54cf5f6c5ce7f14e8aa0a9e339d5
cdk · May 15, 2012 · 2a2aecc · 2a2aecc
1 parent 4205ab5
commit 2a2aecc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/org/openscience/cdk/DefaultChemObjectBuilder.java b/src/main/org/openscience/cdk/DefaultChemObjectBuilder.java
@@ -383,7 +383,7 @@ private <T extends ICDKObject>T newElectronContainerInstance(
 	            return (T)new Bond();
 	        } else if (params.length == 2 &&
 	                params[0] instanceof IAtom &&
-	                params[0] instanceof IAtom) {
+	                params[1] instanceof IAtom) {
 	            return (T)new Bond((IAtom)params[0], (IAtom)params[1]);
 	        } else if (params.length == 3 &&
 	                params[0] instanceof IAtom &&

diff --git a/src/main/org/openscience/cdk/silent/SilentChemObjectBuilder.java b/src/main/org/openscience/cdk/silent/SilentChemObjectBuilder.java
@@ -376,7 +376,7 @@ private <T extends ICDKObject>T newElectronContainerInstance(
 	            return (T)new Bond();
 	        } else if (params.length == 2 &&
 	                params[0] instanceof IAtom &&
-	                params[0] instanceof IAtom) {
+	                params[1] instanceof IAtom) {
 	            return (T)new Bond((IAtom)params[0], (IAtom)params[1]);
 	        } else if (params.length == 3 &&
 	                params[0] instanceof IAtom &&