Merge pull request #727 from vigsterkr/so

Fix memory leak in libp3bm
shogun-toolbox · Aug 17, 2012 · 2b6d30f · 2b6d30f
2 parents 7636b27 + 6f08f28
commit 2b6d30f
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/shogun/structure/libp3bm.cpp b/src/shogun/structure/libp3bm.cpp
@@ -746,6 +746,7 @@ bmrm_return_value_T svm_p3bm_solver(
 		cp_ptr2=cp_ptr;
 		cp_ptr=cp_ptr->next;
 		LIBBMRM_FREE(cp_ptr2);
+		cp_ptr2 = NULL;
 	}
 
 cleanup:
@@ -773,11 +774,19 @@ bmrm_return_value_T svm_p3bm_solver(
 	LIBBMRM_FREE(H2);
 	LIBBMRM_FREE(C);
 	LIBBMRM_FREE(S);
+	LIBBMRM_FREE(Rt);
+
+	if (cp_list)
+		LIBBMRM_FREE(cp_list);
 
 	for (uint32_t p=0; p<cp_models; ++p)
+	{
 		LIBBMRM_FREE(subgrad_t[p]);
+		LIBBMRM_FREE(info[p]);
+	}
 
 	LIBBMRM_FREE(subgrad_t);
+	LIBBMRM_FREE(info);
 
 	return(p3bmrm);
 }