Fix numeric underflow on calculating window size adjustment

sapier · sapier · commit 09e8bbea03c7 · 2014-05-04T02:43:01.000+02:00
diff --git a/src/connection.cpp b/src/connection.cpp
@@ -716,7 +716,7 @@ void Channel::UpdateTimers(float dtime,bool legacy_peer)
 			packet_too_late = current_packet_too_late;
 			packets_successfull = current_packet_successfull;
 
-			if (current_bytes_transfered > (window_size*512/2))
+			if (current_bytes_transfered > (unsigned int) (window_size*512/2))
 			{
 				reasonable_amount_of_data_transmitted = true;
 			}
diff --git a/src/connection.h b/src/connection.h
@@ -546,7 +546,7 @@ class Channel
 	void setWindowSize(unsigned int size) { window_size = size; };
 private:
 	JMutex m_internal_mutex;
-	unsigned int window_size;
+	int window_size;
 
 	u16 next_incoming_seqnum;
 

Original file line number	Diff line number	Diff line change
`@@ -716,7 +716,7 @@ void Channel::UpdateTimers(float dtime,bool legacy_peer)`
`716`	`716`	`packet_too_late = current_packet_too_late;`
`717`	`717`	`packets_successfull = current_packet_successfull;`
`718`	`718`
`719`		`- if (current_bytes_transfered > (window_size*512/2))`
	`719`	`+ if (current_bytes_transfered > (unsigned int) (window_size*512/2))`
`720`	`720`	`{`
`721`	`721`	`reasonable_amount_of_data_transmitted = true;`
`722`	`722`	`}`