Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: http-party/node-http-proxy
base: aba505d159a7
Choose a base ref
...
head repository: http-party/node-http-proxy
compare: 3194d819b422
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Nov 24, 2014

  1. Set Content-Length header for OPTIONS requests

    Web browsers automatically issue an OPTIONS request in advance of other
    HTTP requests when the document's domain does not match the target in
    order to facilitate Cross-Origin Resource Sharing. These requests are
    forbidden from specifying a body and typically do not specify an
    (unecessary) `Length` header.
    
    Node.js automatically adds the `Content-Encoding: chunked` header value
    to requests that do not specify a `Length` header. This makes proxied
    OPTIONS requests from web browsers invalid.
    
    Explicitly set the `Content-Length` header of all `OPTIONS` requests to
    "0", disabling the default "chunked" encoding behavior [2].
    
    [1] http://www.w3.org/TR/cors/
    [2] http://nodejs.org/api/http.html
    jugglinmike committed Nov 24, 2014
    Copy the full SHA
    8a24a1e View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2014

  1. Merge pull request #742 from jugglinmike/option-content-length

    Set `Content-Length` header for OPTIONS requests
    jcrugzz committed Nov 25, 2014
    Copy the full SHA
    3194d81 View commit details
    Browse the repository at this point in the history