Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow FederaUser read action for root #269

Closed
wants to merge 1 commit into from

Conversation

yulgit1
Copy link
Contributor

@yulgit1 yulgit1 commented Mar 19, 2014

with auth on there was no access to root as there are no roles associated with it, added logic to pass this condition

"root/ (default content roles, i.e. no roles for anyone)"
from
https://wiki.duraspace.org/display/FF/Authentication+and+Authorization

@@ -145,6 +145,11 @@ public boolean hasPermission(final Context context, final Path absPath,
return actions.length == 1 && "read".equals(actions[0]);
}

//this permission is required for root access
if (absPath.isRoot()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an "OR" in the previous "if" clause would be cleaner.
Also, what scenario does the previous "absPath == null" cover?

@awoods
Copy link

awoods commented Mar 21, 2014

No commiting at this point.

@awoods awoods closed this Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants