TRUNK-4129 Modify datatype of drug_order.quantity column and add quantity_units column to drug_order #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1052,6 +1052,8 @@ private static String getVersion() { | |||
|
|
|||
| public static final String GLOBAL_PROPERTY_NEXT_ORDER_NUMBER = "orderEntry.nextOrderNumber"; | |||
|
|
|||
| public static final String GP_DRUG_ORDER_UNITS_TO_QUANTITY_UNITS = "drugOrder.unitsToQuantityUnits"; | |||
There was a problem hiding this comment.
I don' think you need separate GP for this, there will be a single GP that is comma separated for all mappings, it will contain something like drug_order_quantity_units:5032 the represents the mapping to the concept with id 5032 as the quantity units for all existing drug_order.quantity values
quantity_units column to drug_order
|
Merged the code at 2e3c7cf |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* ErrorState added to esm-styleguide. All tests passing * Core ErrorState is working * documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.openmrs.org/browse/TRUNK-4129
This is ready to be merged. I'm still working on a migration changeset, which will use the drugOrder.unitsToQuantityUnits gp to migrate freetext units to coded quantityUnits.