improved Mojo::Collection performance

mojolicious · Jul 24, 2014 · a9a574a · a9a574a
1 parent cdee141
commit a9a574a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/Changes b/Changes
@@ -2,6 +2,7 @@
 5.17  2014-07-24
   - Welcome to the Mojolicious core team Jan Henning Thorsen.
   - Added val method to Mojo::DOM. (batman, sri)
+  - Improved Mojo::Collection performance.
 
 5.16  2014-07-21
   - Improved Mojo::Asset::File to allow appending data to existing files.

diff --git a/lib/Mojo/Collection.pm b/lib/Mojo/Collection.pm
@@ -26,7 +26,7 @@ sub DESTROY { }
 sub c { __PACKAGE__->new(@_) }
 
 sub compact {
-  shift->grep(sub { length($_ // '') });
+  $_[0]->new(grep { defined $_ && (ref $_ || length $_) } @{$_[0]});
 }
 
 sub each {
@@ -70,7 +70,7 @@ sub new {
 
 sub pluck {
   my ($self, $method, @args) = @_;
-  return $self->map(sub { $_->$method(@args) });
+  return $self->new(map { $_->$method(@args) } @$self);
 }
 
 sub reverse { $_[0]->new(reverse @{$_[0]}) }
@@ -93,7 +93,7 @@ sub tap { shift->Mojo::Base::tap(@_) }
 
 sub uniq {
   my %seen;
-  return shift->grep(sub { !$seen{$_}++ });
+  return $_[0]->new(grep { !$seen{$_}++ } @{$_[0]});
 }
 
 sub _flatten {

diff --git a/lib/Mojo/DOM.pm b/lib/Mojo/DOM.pm
@@ -547,10 +547,10 @@ from L<Mojo::DOM::CSS/"SELECTORS"> are supported.
 
 =head2 attr
 
-  my $attrs = $dom->attr;
-  my $foo   = $dom->attr('foo');
-  $dom      = $dom->attr({foo => 'bar'});
-  $dom      = $dom->attr(foo => 'bar');
+  my $hash = $dom->attr;
+  my $foo  = $dom->attr('foo');
+  $dom     = $dom->attr({foo => 'bar'});
+  $dom     = $dom->attr(foo => 'bar');
 
 This element's attributes.