Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split controller #575

Merged
merged 12 commits into from Jun 25, 2013
Merged

Split controller #575

merged 12 commits into from Jun 25, 2013

Conversation

emanuele45
Copy link
Contributor

No description provided.

norv
norv reviewed Jun 22, 2013
View reviewed changes
sources/controllers/SplitTopics.controller.php
'selected' => array(),
);
$request = $db->query('', '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good to see! 😸 I was wondering if there are more queries, which can be replaced with calls to those split-merge-specific functions (messageAt(), messagesSince() that kind of subs stuff).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better now? 👼

@norv
Copy link
Contributor

norv commented Jun 23, 2013

git co emanuele/split_controller
Go to a topic with two pages -> split
=> PHP Fatal error: Unsupported operand types in /.../sources/Subs.php on line 593

@norv
Copy link
Contributor

norv commented Jun 23, 2013

git pull -f emanuele split_controller:ema_split
Go to a topic with two pages -> split, choose to select each message -> move a few messages to the new topic -> try to move them back to the old topic -> they don't get moved. (not removed from the selection to the right)

ETA: I think the session isn't cleared normally in some circumstance.

@emanuele45
Missing div that prevented change the page index when splitting ajaxi…
a83336f 
…vely a topic

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Even for xml actions we need index.template.php because in certain ca…
761239d 
…ses we need template_init...

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
A $db not used
16f6315 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Removed a couple of queries from SplitTopics_Controller reusing and e…
5106444 
…xpanding the messageAt function

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
/me thinks these functions belong to Topic.subs.php
73e7fbb 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
changed parameter to messageAt in only_approved instead
fd26b1c 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Some missing "IF NOT EXISTS" in upgrades
ad139cf 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Revert "A $db not used"
5f43872 
This reverts commit 0e5fc3534bf024360d14f00f24c55e28cf58a108.

Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Badly initialized variable... - Thanks Norv
4711041 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Fix some undefined indexes due to the recent changes somewhere
ac3ea98 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

git pull elk master
git rebase master
Go to topic, try to split: undefined indexes FTW! :P
There are many in PMs to, will probably check what is broken on the other branch.

Regarding that #575 (comment) it may take a while, I'm not sure what's wrong...

@emanuele45
Fixed stupid error - Thanks Norv!
2eb7603 
Signed-off-by: emanuele <emanuele45@gmail.com>
@emanuele45
Copy link
Contributor Author

lol
It didn't take that much... :P

@emanuele45
$_SESSION stored in variable and passed to countSplitMessages - Thanks
816c694 
Norv for the suggestion

Signed-off-by: emanuele <emanuele45@gmail.com>
@norv
Copy link
Contributor

norv commented Jun 25, 2013

Thanks for the fixes Ema. I'd merge this, split and merge controllers can only benefit from refactorings... I really think we'll debug eventual issues much better when we finish them, actually. With cleaner and separated code bugs are easier to spot and fix.

norv added a commit that referenced this pull request Jun 25, 2013
@norv
Merge pull request #575 from emanuele45/split_controller
a7794ab 
Split controller
@norv norv merged commit a7794ab into elkarte:master Jun 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emanuele45 @norv