Trunk 4033 #390
Closed
Trunk 4033 #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @see OpenmrsConstants#GLOBAL_PROPERTY_ENCOUNTER_TYPES_LOCKED | ||
| * @see PersonService#checkIfLocked() | ||
| */ |
There was a problem hiding this comment.
Add @SInCE 1.10 added to 1.8.5 and 1.9.4
|
@joseph, in the description of the PR, you need to include the url of the ticket instead of just the ticket number |
| @@ -121,7 +121,7 @@ | |||
| <h4><openmrs:message code="EncounterType.unretireEncounterType"/></h4> | |||
|
|
|||
| <br/> | |||
| <input type="submit" value='<openmrs:message code="EncounterType.unretireEncounterType"/>' name="unretire"/> | |||
There was a problem hiding this comment.
You need to hide/disable all edit, save, retire, unretire, purge/delete buttons on the form
…_shouldNotSaveEncounterTypeIfEncounterTypesAreLocked()
| EncounterType encounterType = new EncounterType("testing", "desc"); | ||
|
|
||
| String locked = Context.getAdministrationService().getGlobalProperty( | ||
| OpenmrsConstants.GLOBAL_PROPERTY_ENCOUNTER_TYPES_LOCKED, "false"); |
There was a problem hiding this comment.
This test method seems not quite right, it says should not save encounter type of locked but you are doing the opposite, your test should using @test(expected) to check that the exception was thrown and not use the if clause
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for [Trunk 4033] locking mechanism for encounter_type