Skip to content

Commit

Permalink
Removed stale FIXME in IRBuilder -- fixed long back
Browse files Browse the repository at this point in the history
  • Loading branch information
subbuss committed Nov 2, 2014
1 parent 8dc5296 commit 0d3a9bc
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions core/src/main/java/org/jruby/ir/IRBuilder.java
Expand Up @@ -2810,10 +2810,6 @@ public Operand buildOpAsgnAnd(OpAsgnAndNode andNode, IRScope s) {
return result;
}

// FIXME: This logic is not quite right....marked extra branch checks
// to make sure the value is not defined but nil. Nil will trigger ||=
// rhs expression.
//
// "x ||= y"
// --> "x = (is_defined(x) && is_true(x) ? x : y)"
// --> v = -- build(x) should return a variable! --
Expand Down

0 comments on commit 0d3a9bc

Please sign in to comment.