small optimizations

mojolicious · Oct 13, 2013 · f7a103d · f7a103d
1 parent f46fb07
commit f7a103d
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 8 deletions.
diff --git a/lib/Mojo/Path.pm b/lib/Mojo/Path.pm
@@ -67,7 +67,7 @@ sub merge {
 sub parse {
   my $self = shift;
   $self->{path} = shift;
-  delete $self->{$_} for qw(leading_slash parts trailing_slash);
+  delete @$self{qw(leading_slash parts trailing_slash)};
   return $self;
 }
 

diff --git a/lib/Mojo/Server/Hypnotoad.pm b/lib/Mojo/Server/Hypnotoad.pm
@@ -134,7 +134,7 @@ sub _reap {
   # Clean up failed upgrade
   return unless ($self->{new} || '') eq $pid;
   $self->{prefork}->app->log->info('Zero downtime software upgrade failed.');
-  delete $self->{$_} for qw(new upgrade);
+  delete @$self{qw(new upgrade)};
 }
 
 sub _stop {

diff --git a/lib/Mojo/Server/Prefork.pm b/lib/Mojo/Server/Prefork.pm
@@ -206,7 +206,7 @@ sub _spawn {
   # Clean worker environment
   $SIG{$_} = 'DEFAULT' for qw(INT TERM CHLD TTIN TTOU);
   $SIG{QUIT} = sub { $loop->max_connections(0) };
-  delete $self->{$_} for qw(poll reader);
+  delete @$self{qw(poll reader)};
 
   $self->app->log->debug("Worker $$ started.");
   $loop->start;

diff --git a/lib/Mojo/UserAgent.pm b/lib/Mojo/UserAgent.pm
@@ -80,7 +80,7 @@ sub start {
   # Fork safety
   unless (($self->{pid} //= $$) eq $$) {
     $self->_cleanup;
-    delete $self->{$_} for qw(pid port);
+    delete @$self{qw(pid port)};
   }
 
   # Non-blocking

diff --git a/lib/Mojolicious/Controller.pm b/lib/Mojolicious/Controller.pm
@@ -449,7 +449,7 @@ sub _fallbacks {
   # Inline template
   my $stash = $self->stash;
   return undef unless $stash->{format} eq 'html';
-  delete $stash->{$_} for qw(extends layout);
+  delete @$stash{qw(extends layout)};
   return $self->render_maybe(%$options, inline => $inline, handler => 'ep');
 }
 

diff --git a/lib/Mojolicious/Routes/Match.pm b/lib/Mojolicious/Routes/Match.pm
@@ -72,7 +72,7 @@ sub _match {
   if (($endpoint && $empty) || $r->inline) {
     push @{$self->stack}, {%$captures};
     return $self->endpoint($r) if $endpoint && $empty;
-    delete $captures->{$_} for qw(app cb);
+    delete @$captures{qw(app cb)};
   }
 
   # Match children

diff --git a/t/mojolicious/dispatch.t b/t/mojolicious/dispatch.t
@@ -15,7 +15,7 @@ sub reset_state {
   my $self = shift;
   $self->render_called(0);
   my $stash = $self->stash;
-  delete $stash->{$_} for keys %$stash;
+  delete @$stash{keys %$stash};
 }
 
 package main;

diff --git a/t/mojolicious/dispatcher_lite_app.t b/t/mojolicious/dispatcher_lite_app.t
@@ -20,7 +20,7 @@ hook around_dispatch => sub {
   $next->();
   if ($c->res->code == 404) {
     $c->req->url->path($c->param('wrap') ? '/wrap/again' : '/');
-    delete $c->stash->{$_} for keys %{$c->stash};
+    delete @{$c->stash}{keys %{$c->stash}};
     $c->tx->res(Mojo::Message::Response->new);
     $next->();
   }