Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ac4df73bd176
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7bacd7e85fd1
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Oct 23, 2014

  1. Use BasicObject#hash For Hash#hash

    @elia
    elia committed Oct 23, 2014
    Copy the full SHA
    17fb5ca View commit details

  2. Ensure the $$id is generated via __id__

    @elia
    elia committed Oct 23, 2014
    Copy the full SHA
    7bacd7e View commit details
Showing with 1 addition and 5 deletions.
  1. +0 −4 opal/corelib/hash.rb
  2. +1 −1 opal/corelib/kernel.rb
4 changes: 0 additions & 4 deletions opal/corelib/hash.rb
View file
Original file line number Diff line number Diff line change
@@ -374,10 +374,6 @@ def has_value?(value)
}
end

def hash
`self.$$id`
end

alias include? has_key?

def index(object)
2 changes: 1 addition & 1 deletion opal/corelib/kernel.rb
View file
Original file line number Diff line number Diff line change
@@ -289,7 +289,7 @@ def format(format, *args)
end

def hash
`[self.$$class.$$name,self.$$class.$$id,self.$$id].join(':')`
`[self.$$class.$$name,#{`self.$$class`.__id__},#{__id__}].join(':')`
end

def initialize_copy(other)