Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill methods #487

Closed
wants to merge 3 commits into from
Closed

Kill methods #487

wants to merge 3 commits into from

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Sep 24, 2014

@cbeer
Copy link
Contributor Author

cbeer commented Sep 24, 2014

@ajs6f @barmintor @awoods @escowles ? Anyone want to offer a defense for any of these commits?

@ajs6f
Copy link
Contributor

ajs6f commented Sep 24, 2014

You mean a defense for the stuff you're killing? No, I'll happily hold your coat while you punch it to death, and I'll pour you a beer afterwards. If the tests pass and the surface of our API remains substantially the same, then these methods should have been long gone. I am a little weirded about POST-for-DELETE, but then, batch delete actions across RESTful HTTP always end up looking a bit weird, because

9.7 DELETE
The DELETE method requests that the origin server delete the resource identified by the Request-URI.

@cbeer
Copy link
Contributor Author

cbeer commented Sep 25, 2014

Split into separate PRs

@cbeer cbeer closed this Sep 25, 2014
@cbeer cbeer deleted the kill-methods branch October 17, 2014 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants