Allow selecting any user with privileges when filtering by bug note

rombert · rombert · commit b3d05226e54b · 2012-09-15T11:14:26.000+03:00
reporter Fix based on patch attached by frodgers at http://www.mantisbt.org/bugs/view.php?id=9725 . Fixes #9725: Filter on "Note By" by a reporter
diff --git a/core/filter_api.php b/core/filter_api.php
@@ -3950,7 +3950,7 @@ function print_filter_note_user_id() {
 					echo '>[' . lang_get( 'myself' ) . ']</option>';
 				}
 
-				print_assign_to_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );
+				print_note_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );
 			}
 		?>
         </select>
diff --git a/core/print_api.php b/core/print_api.php
@@ -458,6 +458,15 @@ function print_assign_to_option_list( $p_user_id = '', $p_project_id = null, $p_
 	print_user_option_list( $p_user_id, $p_project_id, $p_threshold );
 }
 
+
+function print_note_option_list( $p_user_id = '', $p_project_id = null, $p_threshold = null ) {
+	if ( null === $p_threshold ) {
+		$p_threshold = config_get( 'add_bugnote_threshold' );
+	}
+	
+	print_user_option_list( $p_user_id, $p_project_id, $p_threshold );
+}
+
 /**
  * List projects that the current user has access to.
  *
@@ -860,7 +869,7 @@ function print_enum_string_option_list( $p_enum_name, $p_val = 0 ) {
 	}
 }
 
-/*
+/**
  * Returns a list of valid status options based on workflow
  * @param int $p_user_auth User's access level
  * @param int $p_current_value Current issue's status

Original file line number	Diff line number	Diff line change
`@@ -3950,7 +3950,7 @@ function print_filter_note_user_id() {`
`3950`	`3950`	`echo '>[' . lang_get( 'myself' ) . ']</option>';`
`3951`	`3951`	`}`
`3952`	`3952`
`3953`		`- print_assign_to_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );`
	`3953`	`+ print_note_option_list( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] );`
`3954`	`3954`	`}`
`3955`	`3955`	`?>`
`3956`	`3956`	`</select>`
Original file line number	Diff line number	Diff line change
`@@ -458,6 +458,15 @@ function print_assign_to_option_list( $p_user_id = '', $p_project_id = null, $p_`
`458`	`458`	`print_user_option_list( $p_user_id, $p_project_id, $p_threshold );`
`459`	`459`	`}`
`460`	`460`
	`461`	`+`
	`462`	`+function print_note_option_list( $p_user_id = '', $p_project_id = null, $p_threshold = null ) {`
	`463`	`+ if ( null === $p_threshold ) {`
	`464`	`+ $p_threshold = config_get( 'add_bugnote_threshold' );`
	`465`	`+ }`
	`466`	`+`
	`467`	`+ print_user_option_list( $p_user_id, $p_project_id, $p_threshold );`
	`468`	`+}`
	`469`	`+`
`461`	`470`	`/**`
`462`	`471`	`* List projects that the current user has access to.`
`463`	`472`	`*`
`@@ -860,7 +869,7 @@ function print_enum_string_option_list( $p_enum_name, $p_val = 0 ) {`
`860`	`869`	`}`
`861`	`870`	`}`
`862`	`871`
`863`		`-/*`
	`872`	`+/**`
`864`	`873`	`* Returns a list of valid status options based on workflow`
`865`	`874`	`* @param int $p_user_auth User's access level`
`866`	`875`	`* @param int $p_current_value Current issue's status`