Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bb676ff431a1
Choose a base ref
...
head repository: mantisbt/mantisbt
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9344b94510d7
Choose a head ref
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Aug 31, 2012

  1. Fix system notice in manage_user_page.php 

    Removed comments left by 93eb540
    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    6aaf95d View commit details

  2. Add optional param to columns_get_standard() to return all columns 

    The default behavior is to exclude the fields which are not "active" due
to config settings. The new parameter lets caller override that to
return all standard columns (ie. excluding custom fields).
    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    9f57d94 View commit details

  3. Whitespace changes

    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    de88784 View commit details

  4. Install helper api - new function install_set_log_queries() 

    The new function is used by install/upgrade callback functions to ensure
that only the relevant queries are logged. This avoids code duplication
in each function.
    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    33f3216 View commit details

  5. Add upgrade step to replace truncated custom field names in history 

    Function custom_field_get_id_from_name() contained code to check for
truncated custom fields names. This dates back to when the history
table's field_name column was only 32 chars long, whereas the custom
field's size is 64.

The history's field_name size has been increased to 64 since 1.1.0a4
(see issue #8002), so the check has been removed from the code and
replaced by an upgrade step (calling new install helper function
install_update_history_long_custom_fields(), which converts legacy
history entries storing truncated custom field names by their expanded
full name.

Fixes #14650
    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    ce3450a View commit details

  6. Fix SQL error when sorting by custom field containing special char 

    Incorrect behavior is due to unnecessarily escaping of special chars by
calling db_prepare_string() on the custom field's name before attempting
to retrieve it's id with custom_field_get_id_from_name(). This causes a
double-escaping which prevents a match.

Even though this is not strictly necessary to fix the issue at hand,
this commit also replaces db_query() call by db_query_bound() in
custom_field_get_id_from_name().

Fixes #12170
    @dregad
    dregad committed Aug 31, 2012
    Copy the full SHA
    9344b94 View commit details
Loading