Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 120f7cf55fb9
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 17fbdc18b8ce
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on May 7, 2014

  1. lib: name EventEmitter prototype methods 

    Before this commit the EventEmitter methods were anonymous functions.
V8 tries to infer names for anonymous functions based on the execution
context but it frequently gets it wrong and when that happens, the
stack trace is usually confusing and unhelpful.  This commit names all
methods so V8 can fall back to the method.name property.

The above gotcha applies to all anonymous functions but is exacerbated
for EventEmitter methods because those are invoked with a plenitude of
different receivers.

Signed-off-by: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis @trevnorris
    bnoordhuis authored and trevnorris committed May 7, 2014
    Copy the full SHA
    17fbdc1 View commit details
    Browse the repository at this point in the history