switch from BREAK_ONE to BREAK_ALL

mojolicious · Mar 21, 2012 · 390d5ff · 390d5ff
1 parent 3293de7
commit 390d5ff
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/lib/Mojo/Reactor.pm b/lib/Mojo/Reactor.pm
@@ -113,10 +113,12 @@ sub watch {
 
 sub _timer {
   my ($self, $cb) = (shift, shift);
+
   my $t = {cb => $cb, @_};
   my $id;
   do { $id = md5_sum('t' . time . rand 999) } while $self->{timers}->{$id};
   $self->{timers}->{$id} = $t;
+
   return $id;
 }
 

diff --git a/lib/Mojo/Reactor/EV.pm b/lib/Mojo/Reactor/EV.pm
@@ -21,7 +21,7 @@ sub recurring { shift->_timer(shift, 1, @_) }
 #  Yeah... where do I fill it up?"
 sub start {EV::run}
 
-sub stop { EV::break(EV::BREAK_ONE) }
+sub stop { EV::break(EV::BREAK_ALL) }
 
 sub timer { shift->_timer(shift, 0, @_) }
 

diff --git a/t/mojo/reactor_ev.t b/t/mojo/reactor_ev.t
@@ -215,7 +215,7 @@ Mojo::IOLoop->client(
     $client_err = $@;
   }
 );
-Mojo::IOLoop->timer(1 => sub { EV::break(EV::BREAK_ONE()) });
+Mojo::IOLoop->timer(1 => sub { EV::break(EV::BREAK_ALL()) });
 EV::run();
 ok !Mojo::IOLoop->is_running, 'loop is not running';
 like $server_err, qr/^Mojo::IOLoop already running/, 'right error';