Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude httpclient from fcrepo-integration-ldp project. #558

Closed

Conversation

awoods
Copy link

@awoods awoods commented Oct 17, 2014

No description provided.

@@ -159,6 +159,10 @@
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
</exclusion>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we're counting on the LDP integration tests to never need this module, or is there some magic going on?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency graph of LDP integration tests has httpclient as a test-scope dependency of a nested dependency... and, not surprisingly, excluding httpclient had no effect on running the integration tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, because we are using the LDP integration tests as a test dependency, we got test dependencies for its dependencies?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To show what the dependency tree looks like without the exclusion of httpclient, I temporarily removed that exclusion from fcrepo-integration-ldp/pom.xml, and ran:
mvn dependency:tree -pl fcrepo-integration-ldp/

Here is the pertinent snippet:

[INFO] +- org.openrdf.sesame:sesame-sail-memory:jar:2.7.13:test
[INFO] | +- org.openrdf.sesame:sesame-sail-inferencer:jar:2.7.13:test
[INFO] | | +- org.openrdf.sesame:sesame-queryparser-api:jar:2.7.13:test
[INFO] | | - org.openrdf.sesame:sesame-queryparser-serql:jar:2.7.13:test
[INFO] | - org.openrdf.sesame:sesame-queryalgebra-evaluation:jar:2.7.13:test
[INFO] | +- org.openrdf.sesame:sesame-repository-sparql:jar:2.7.13:test
[INFO] | | +- org.openrdf.sesame:sesame-queryparser-sparql:jar:2.7.13:test
[INFO] | | - org.openrdf.sesame:sesame-queryresultio-sparqlxml:jar:2.7.13:test
[INFO] | - org.openrdf.sesame:sesame-http-client:jar:2.7.13:test
[INFO] | +- org.openrdf.sesame:sesame-http-protocol:jar:2.7.13:test
[INFO] | - commons-httpclient:commons-httpclient:jar:3.1:test

@awoods awoods closed this Oct 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants