Item13186: forgot an essential param

foswiki · Jan 9, 2015 · 6f685c7 · 6f685c7
1 parent a6036b1
commit 6f685c7
Show file tree

Hide file tree

Showing 13 changed files with 17 additions and 17 deletions.
diff --git a/SubscribePlugin/lib/Foswiki/Plugins/SubscribePlugin/Config.spec b/SubscribePlugin/lib/Foswiki/Plugins/SubscribePlugin/Config.spec
@@ -2,9 +2,9 @@
 # ---++ Subscribe Plugin
 # Settings for the Subscribe Plugin.  This plugin adds a simple "Subscribe" link to topics. This allows
 # single-click subscribing or unsubscribing from the WebNotify topic.
-# **STRING 80**
+# **STRING 80 CHECK="undefok emptyok"**
 # Comma-separated list of webs that will get the subscribe button added.  Default is all webs. 
 # Caution:  On webs with extremely large or complex WebNotify topics, the rendering of the Subscribe or Unsubscribe
 # link can take an inordinate amount of time. 
-$Foswiki::cfg{Plugins}{SubscribePlugin}{ActiveWebs} = '';
+$Foswiki::cfg{Plugins}{SubscribePlugin}{ActiveWebs} = undef;
 1;
diff --git a/core/lib/Foswiki.spec b/core/lib/Foswiki.spec
@@ -270,7 +270,7 @@ $Foswiki::cfg{Sessions}{ExpireCookiesAfter} = 0;
 # {Sessions}{MapIP2SID}).
 $Foswiki::cfg{Sessions}{IDsInURLs} = 0;
 
-# **STRING 20 CHECK='undefok' EXPERT DISPLAY_IF="{UseClientSessions}" CHECK="iff:'{UseClientSessions}'"**
+# **STRING 20 CHECK='undefok emptyok' EXPERT DISPLAY_IF="{UseClientSessions}" CHECK="iff:'{UseClientSessions}'"**
 # By default the Foswiki session cookie is only accessible by the host which
 # sets it. To change the scope of this cookie you can set this to any other
 # value (ie. company.com). Make sure that Foswiki can access its own cookie.
@@ -784,7 +784,7 @@ $Foswiki::cfg{Register}{NeedVerification} = $FALSE;
 # to an approval system.
 $Foswiki::cfg{Register}{NeedApproval} = $FALSE;
 
-# **STRING 40**
+# **STRING 40 CHECK="undefok emptyok"**
 # Comma-separated list of WikiNames of users who are able to approve
 # new registrations. These referees will be sent an email when a new
 # user verifies their registration. The referee must click a link in
@@ -1057,7 +1057,7 @@ $Foswiki::cfg{PROXY}{PORT} = undef;
 # public (internet) sites are strongly recommended to install
 # [[http://foswiki.org/Extensions/AntiWikiSpamPlugin][AntiWikiSpamPlugin]]
 
-# **STRING 50**
+# **STRING 50 CHECK="undefok emptyok"**
 # Text added to e-mail addresses to prevent spambots from grabbing
 # addresses. For example set to 'NOSPAM' to get fred@user.co.ru
 # rendered as fred@user.coNOSPAM.ru
@@ -1222,7 +1222,7 @@ $Foswiki::cfg{Stats}{TopContrib} = 10;
 # the previous behavior and is the default.
 $Foswiki::cfg{Stats}{AutoCreateTopic} = 'Prohibited';
 
-# **STRING 20**
+# **STRING 20 CHECK="undefok emptyok"**
 # If this is set to the name of a Group, then the statistics script will only
 # run for members of the specified  and the AdminGroup.  Example:
 # Set to =AdminGroup= to restrict statistics to  administrators.

diff --git a/core/lib/Foswiki/Configure/Checkers/DefaultUrlHost.pm b/core/lib/Foswiki/Configure/Checkers/DefaultUrlHost.pm
@@ -10,7 +10,7 @@ our @ISA = ('Foswiki::Configure::Checkers::URL');
 sub check_current_value {
     my ( $this, $reporter ) = @_;
 
-    my $d = $this->checkExpandedValue();
+    my $d = $this->checkExpandedValue($reporter);
     return unless $d;
     $this->SUPER::check_current_value($reporter);
 

diff --git a/core/lib/Foswiki/Configure/Checkers/Email/SSLCaFile.pm b/core/lib/Foswiki/Configure/Checkers/Email/SSLCaFile.pm
@@ -15,7 +15,7 @@ sub check_current_value {
       unless ( $Foswiki::cfg{Email}{MailMethod} =~ /^Net::SMTP/
         && $Foswiki::cfg{Email}{SSLVerifyServer} );
 
-    my $file = $this->checkExpandedValue();
+    my $file = $this->checkExpandedValue($reporter);
     if ($file) {
         unless ( $file =~ m,^([\w_./]+)$, ) {
             return $this->ERROR("Invalid characters in $file");

diff --git a/core/lib/Foswiki/Configure/Checkers/Email/SSLCaPath.pm b/core/lib/Foswiki/Configure/Checkers/Email/SSLCaPath.pm
@@ -20,7 +20,7 @@ sub check_current_value {
     if ( $file && !-r $file ) {
         $reporter->ERROR("Unable to read $file");
     }
-    my $path = $this->checkExpandedValue();
+    my $path = $this->checkExpandedValue($reporter);
     if ($path) {
         if ( !( -d $path && -r _ ) ) {
             $reporter->ERROR(

diff --git a/core/lib/Foswiki/Configure/Checkers/Email/SSLCrlFile.pm b/core/lib/Foswiki/Configure/Checkers/Email/SSLCrlFile.pm
@@ -13,7 +13,7 @@ sub check_current_value {
 
     return '' unless ( $Foswiki::cfg{Email}{SSLCheckCRL} );
 
-    my $value = $this->checkExpandedValue();
+    my $value = $this->checkExpandedValue($reporter);
 
     # TODO: move this to a wizard?
     #    unless ( $value || $Foswiki::cfg{Email}{SSLCaPath} ) {

diff --git a/core/lib/Foswiki/Configure/Checkers/LANGUAGE.pm b/core/lib/Foswiki/Configure/Checkers/LANGUAGE.pm
@@ -22,7 +22,7 @@ sub check_current_value {
 
     return unless ( $Foswiki::cfg{UserInterfaceInternationalisation} );
 
-    my $enabled = $this->checkExpandedValue();
+    my $enabled = $this->checkExpandedValue($reporter);
     return unless $enabled;
 
     my $dir = $Foswiki::cfg{LocalesDir};

diff --git a/core/lib/Foswiki/Configure/Checkers/Log/Dir.pm b/core/lib/Foswiki/Configure/Checkers/Log/Dir.pm
@@ -16,7 +16,7 @@ sub check_current_value {
         $Foswiki::cfg{Log}{Dir} = "$Foswiki::cfg{WorkingDir}/logs";
     }
 
-    my $ld = $this->checkExpandedValue();
+    my $ld = $this->checkExpandedValue($reporter);
     return unless defined $ld;
 
     ($ld) = $ld =~ m/^(.*)$/;    # Untaint

diff --git a/core/lib/Foswiki/Configure/Checkers/NUMBER.pm b/core/lib/Foswiki/Configure/Checkers/NUMBER.pm
@@ -21,7 +21,7 @@ our @ISA = ('Foswiki::Configure::Checker');
 sub check_current_value {
     my ( $this, $reporter ) = @_;
 
-    my $val = $this->checkExpandedValue();
+    my $val = $this->checkExpandedValue($reporter);
     return unless defined $val;
 
     if ( $val !~ /^\s*[-+]?[0-9]*\.?[0-9]+([eE][-+]?[0-9]+)?\s*$/ ) {

diff --git a/core/lib/Foswiki/Configure/Checkers/OCTAL.pm b/core/lib/Foswiki/Configure/Checkers/OCTAL.pm
@@ -20,7 +20,7 @@ our @ISA = ('Foswiki::Configure::Checkers::NUMBER');
 sub check_current_value {
     my ( $this, $reporter ) = @_;
 
-    my $val = $this->checkExpandedValue();
+    my $val = $this->checkExpandedValue($reporter);
     return unless defined $val;
 
     my $min = $this->CHECK_option('min');

diff --git a/core/lib/Foswiki/Configure/Checkers/SMTP/SENDERHOST.pm b/core/lib/Foswiki/Configure/Checkers/SMTP/SENDERHOST.pm
@@ -16,7 +16,7 @@ sub check_current_value {
       unless ( $Foswiki::cfg{EnableEmail}
         && $Foswiki::cfg{Email}{MailMethod} =~ /^Net::SMTP/ );
 
-    my $value = $this->checkExpandedValue();
+    my $value = $this->checkExpandedValue($reporter);
     return unless defined $value;
 
     my $hi = hostInfo($value);

diff --git a/core/lib/Foswiki/Configure/Checkers/STRING.pm b/core/lib/Foswiki/Configure/Checkers/STRING.pm
@@ -23,7 +23,7 @@ our @ISA = ('Foswiki::Configure::Checker');
 sub check_current_value {
     my ( $this, $reporter ) = @_;
 
-    my $value = $this->checkExpandedValue();
+    my $value = $this->checkExpandedValue($reporter);
     return unless defined $value;
 
     my $len = length($value);

diff --git a/core/lib/Foswiki/Configure/Checkers/WorkingDir.pm b/core/lib/Foswiki/Configure/Checkers/WorkingDir.pm
@@ -12,7 +12,7 @@ use Foswiki::Configure::FileUtil ();
 sub check_current_value {
     my ( $this, $reporter ) = @_;
 
-    my $d = $this->checkExpandedValue();
+    my $d = $this->checkExpandedValue($reporter);
     return unless defined $d;
 
     if ( -d $d ) {