Adding class method for view tag_name and class_name #22
Conversation
|
We currently have a bug (to put it lightly) where all class variables are actually set on the same object, i.e. if we set a class variable on any class it will overwrite any class variable of the same name on any other class. We need to fix this first. In the meantime, it might be a good idea to change the implementation here to not use class variables, as the next opal release might not be for a few weeks etc. Thanks for the pull request though, it does make it nicer than the current impl. |
|
Hey, Thanks for the feedback, I'll change the implementation and update the request :) |
As per Adam instructions, class variable should be avoided at the moment, so making a new implementation method based
|
Changed the implementation to something method based. Tell me what you think. |
|
Hey, looking good to me, so merging in. Many thanks for the commit! 😄 |
…class_method Adding class method for view tag_name and class_name
|
Thx for merging :) |
Hello,
I think to have to redefine the tag_name and class_name method in the views to configure them could be improved. Here I propose to promote them to class method, so the configuration would be in the same style than for the element attribute. I implemented it in a backward compatible way.
Tell me if you want any improvements on it.
Loïc