better argument names

mojolicious · Sep 3, 2012 · e23ffcd · e23ffcd
1 parent b8fb859
commit e23ffcd
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/lib/Mojo/ByteStream.pm b/lib/Mojo/ByteStream.pm
@@ -39,13 +39,13 @@ sub clone {
 }
 
 sub decode {
-  my ($self, $e) = @_;
-  return $self->tap(sub { $$_ = Mojo::Util::decode $e || 'UTF-8', $$_ });
+  my ($self, $enc) = @_;
+  return $self->tap(sub { $$_ = Mojo::Util::decode $enc || 'UTF-8', $$_ });
 }
 
 sub encode {
-  my ($self, $e) = @_;
-  return $self->tap(sub { $$_ = Mojo::Util::encode $e || 'UTF-8', $$_ });
+  my ($self, $enc) = @_;
+  return $self->tap(sub { $$_ = Mojo::Util::encode $enc || 'UTF-8', $$_ });
 }
 
 sub say {

diff --git a/lib/Mojo/DOM.pm b/lib/Mojo/DOM.pm
@@ -163,8 +163,8 @@ sub parent {
 }
 
 sub parse {
-  my ($self, @args) = @_;
-  return $self->tap(sub { $_->[0]->parse(@args) });
+  my ($self, $html) = @_;
+  return $self->tap(sub { $_->[0]->parse($html) });
 }
 
 sub prepend { shift->_add(0, @_) }

diff --git a/lib/Mojo/Transaction.pm b/lib/Mojo/Transaction.pm
@@ -41,10 +41,10 @@ sub is_writing {
 }
 
 sub remote_address {
-  my ($self, @args) = @_;
+  my ($self, $address) = @_;
 
   # New address
-  return $self->tap(sub { $_->{remote_address} = shift @args }) if @args;
+  return $self->tap(sub { $_->{remote_address} = $address }) if $address;
 
   # Reverse proxy
   if ($ENV{MOJO_REVERSE_PROXY}) {

diff --git a/lib/Mojo/Upload.pm b/lib/Mojo/Upload.pm
@@ -10,8 +10,8 @@ has [qw(filename name)];
 has headers => sub { Mojo::Headers->new };
 
 sub move_to {
-  my ($self, @args) = @_;
-  return $self->tap(sub { $_->asset->move_to(@args) });
+  my ($self, $to) = @_;
+  return $self->tap(sub { $_->asset->move_to($to) });
 }
 
 sub size  { shift->asset->size }

diff --git a/lib/Mojolicious/Types.pm b/lib/Mojolicious/Types.pm
@@ -49,10 +49,10 @@ sub detect {
 }
 
 sub type {
-  my ($self, $ext, @args) = @_;
+  my ($self, $ext, $type) = @_;
   my $types = $self->types;
-  return ref $types->{$ext} ? $types->{$ext}[0] : $types->{$ext} unless @args;
-  return $self->tap(sub { $types->{$ext} = shift @args });
+  return ref $types->{$ext} ? $types->{$ext}[0] : $types->{$ext} unless $type;
+  return $self->tap(sub { $types->{$ext} = $type });
 }
 
 1;