Navigation Menu

Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: joyent/libuv
base: 39bef3290657^
Choose a base ref
...
head repository: joyent/libuv
compare: faf2c5932c89
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Sep 5, 2013

  1. windows/fs: wrap multi-statement macros in do..while block

    @piscisaureus
    piscisaureus committed Sep 5, 2013
    Copy the full SHA
    39bef32 View commit details
    Browse the repository at this point in the history

  2. windows/fs: make uv_fs_open() report EINVAL correctly 

    Before, when the user passed an invalid paramter to uv_fs_open, libuv
would detect this and call SET_REQ_RESULT to set the result value to -1.
SET_REQ_RESULT then stored whatever error code was returned by
GetLastError(), which would have no relationship to the actual problem,
and might as well be zero.
    @piscisaureus
    piscisaureus committed Sep 5, 2013
    Copy the full SHA
    812717d View commit details
    Browse the repository at this point in the history

  3. windows/fs: handle _open_osfhandle() failure correctly 

    Until now we assumed that _open_osfhandle() would set _doserrno on
failure. This assumption was very wrong in one obvious case, namely when
the CRT file descriptor table would fill up. In that case errno is set
to EMFILE, but GetLastError() returns zero - which makes sense because
it's not a win32 error but rather a CRT problem.
    @piscisaureus
    piscisaureus committed Sep 5, 2013
    Copy the full SHA
    faf2c59 View commit details
    Browse the repository at this point in the history