Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell to rename application.js to js.rb and use ruby require methods #32

Closed
wants to merge 1 commit into from
Closed

Conversation

cantonic
Copy link
Contributor

@cantonic cantonic commented Jan 5, 2015

This fixes a problem with source maps where /asset/opal.map and /assets/opal_ujs.map rspond with 500.
see opal/opal#670

Verified

This commit was signed with the committer’s verified signature. The key has expired.
minijackson Rémi NICOLE
… since it is a ruby file
@elia elia changed the title Tell to rename application.js ro js.rb and use ruby require methods Tell to rename application.js to js.rb and use ruby require methods Jan 5, 2015
@elia
Copy link
Member

elia commented Jan 6, 2015

hey @cantonic thanks for the PR, I'm keeping it on hold just because I need to ponder whether I should just fix the issue instead of publicizing a workaround.

Also should be noted that creating a rails app with rails new -j opal would write an application.js file with the sprockets requires as shown in the current readme.

@cantonic
Copy link
Contributor Author

cantonic commented Jan 6, 2015

Yes, please keep it on hold since someone mentioned that it doesn't fix the source maps problem. I have to recheck it.

@elia
Copy link
Member

elia commented Jan 6, 2015

👍 saw that

@cantonic cantonic closed this Jan 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants