Skip to content

Commit

Permalink
Remove remains of weather
Browse files Browse the repository at this point in the history
  • Loading branch information
@PilzAdam
PilzAdam committed Dec 6, 2014
1 parent 954d64a commit 4ec4672
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 15 deletions.
22 changes: 8 additions & 14 deletions mods/default/nodes.lua
View file
Expand Up @@ -560,9 +560,8 @@ minetest.register_node("default:water_flowing", {
liquid_alternative_flowing = "default:water_flowing",
liquid_alternative_source = "default:water_source",
liquid_viscosity = WATER_VISC,
freezemelt = "default:snow",
post_effect_color = {a=64, r=100, g=100, b=200},
groups = {water=3, liquid=3, puts_out_fire=1, not_in_creative_inventory=1, freezes=1, melt_around=1},
groups = {water=3, liquid=3, puts_out_fire=1, not_in_creative_inventory=1},
})

minetest.register_node("default:water_source", {
Expand Down Expand Up @@ -592,9 +591,8 @@ minetest.register_node("default:water_source", {
liquid_alternative_flowing = "default:water_flowing",
liquid_alternative_source = "default:water_source",
liquid_viscosity = WATER_VISC,
freezemelt = "default:ice",
post_effect_color = {a=64, r=100, g=100, b=200},
groups = {water=3, liquid=3, puts_out_fire=1, freezes=1},
groups = {water=3, liquid=3, puts_out_fire=1},
})

minetest.register_node("default:lava_flowing", {
Expand Down Expand Up @@ -689,7 +687,7 @@ minetest.register_node("default:torch", {
wall_bottom = {-0.1, -0.5, -0.1, 0.1, -0.5+0.6, 0.1},
wall_side = {-0.5, -0.3, -0.1, -0.5+0.3, 0.3, 0.1},
},
groups = {choppy=2,dig_immediate=3,flammable=1,attached_node=1,hot=2},
groups = {choppy=2,dig_immediate=3,flammable=1,attached_node=1},
legacy_wallmounted = true,
sounds = default.node_sound_defaults(),
})
Expand Down Expand Up @@ -1022,7 +1020,7 @@ minetest.register_node("default:furnace_active", {
paramtype2 = "facedir",
light_source = 8,
drop = "default:furnace",
groups = {cracky=2, not_in_creative_inventory=1,hot=1},
groups = {cracky=2, not_in_creative_inventory=1},
legacy_facedir_simple = true,
is_ground_content = false,
sounds = default.node_sound_stone_defaults(),
Expand Down Expand Up @@ -1435,8 +1433,7 @@ minetest.register_node("default:ice", {
tiles = {"default_ice.png"},
is_ground_content = true,
paramtype = "light",
freezemelt = "default:water_source",
groups = {cracky=3, melts=1},
groups = {cracky=3},
sounds = default.node_sound_glass_defaults(),
})

Expand All @@ -1448,16 +1445,14 @@ minetest.register_node("default:snow", {
is_ground_content = true,
paramtype = "light",
buildable_to = true,
leveled = 7,
drawtype = "nodebox",
freezemelt = "default:water_flowing",
node_box = {
type = "leveled",
type = "fixed",
fixed = {
{-0.5, -0.5, -0.5, 0.5, -0.5+2/16, 0.5},
},
},
groups = {crumbly=3,falling_node=1, melts=1, float=1},
groups = {crumbly=3,falling_node=1},
sounds = default.node_sound_dirt_defaults({
footstep = {name="default_snow_footstep", gain=0.25},
dug = {name="default_snow_footstep", gain=0.75},
Expand All @@ -1475,8 +1470,7 @@ minetest.register_node("default:snowblock", {
description = "Snow Block",
tiles = {"default_snow.png"},
is_ground_content = true,
freezemelt = "default:water_source",
groups = {crumbly=3, melts=1},
groups = {crumbly=3},
sounds = default.node_sound_dirt_defaults({
footstep = {name="default_snow_footstep", gain=0.25},
dug = {name="default_snow_footstep", gain=0.75},
Expand Down
2 changes: 1 addition & 1 deletion mods/fire/init.lua
View file
Expand Up @@ -11,7 +11,7 @@ minetest.register_node("fire:basic_flame", {
}},
inventory_image = "fire_basic_flame.png",
light_source = 14,
groups = {igniter=2,dig_immediate=3,hot=3},
groups = {igniter=2,dig_immediate=3},
drop = '',
walkable = false,
buildable_to = true,
Expand Down

13 comments on commit 4ec4672

@gaelysam
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these features were useless in vanilla minetest_game but are used by many mods.
I think it was a mistake to remove them.

@p5yk0g3n3s1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @Gael-de-Sailly please revert this. It will break many mods including one of mine.

@proller
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come to darkside. we have weather ;)
https://github.com/freeminer/default/blob/master/mods/default/nodes.lua

@p5yk0g3n3s1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol The last time I tried freeminer it crashed when I tried playing. It's been some time though I'll have to try it again.

@p5yk0g3n3s1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm about reverting I don't care lol. Mods will just have to conform :).

@PilzAdam
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which features exactly?
@MT-Modder which mod is broken?
Maybe you should create an issue for that.

@p5yk0g3n3s1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't use @Splizard's snow mod but I'm pretty sure removing the freezing and melting groups breaks part of it. Making snow fixed also breaks part of his mod and my better_snow mod. My mod used these groups as well as the freezemelt node definition to freeze water and melt snow and ice. My mod used the leveled snow to freeze specific water levels to a specific snow level.

If @Splizard wants to open an issue he's more than welcome to but I updated my mod to not rely on these things anymore. I know a lot of people use his snow mod so they might have a problem with these changes.

He had to change his mod when weather was removed a while back. Personally I think he should just update it to not rely on these recent changes because they are weather related. Thank you for the reply @PilzAdam.

@Splizard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think snow mod will still work after these group changes, it relies on some of it's own definitions. Lava may no longer melt snow, this is not mod-breaking. Removing leveled nodebox could break snow mod though. I'll have a test and maybe get around to updating snow mod.
I would say this is a digression on mod-compatibility any code removal has the potential to be one.

Thanks for notifying me @MT-Modder

@p5yk0g3n3s1s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I think lava is still in the hot group. If not you could always use the igniter group instead, that's what I did with my mod.

@t4im
Copy link
Contributor

@t4im t4im commented on 4ec4672 Jan 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking snow mod atm Splizard/minetest-mod-snow#7

@gaelysam
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert it. Anyway it changes nothing in vanilla minetest_game (except the leveled snow that was one of the best features of Minetest). At worst, it takes a millisecond more to load it. But it was very useful for many mods. We shouldn't remove this kind of datas. We should even add more ones, even if it's not used in vanilla. Some groups should even become standards.
We need to standardize some things, especially groups, for mods compatibility.
The first of all is weather, every mod defines its own weather, it's the complete mess.

@C1ffisme
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leveled snow is a MUST HAVE. Why did we get rid of it? It's very useful!!!

@Megaf
Copy link
Contributor

@Megaf Megaf commented on 4ec4672 May 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ @Gael-de-Sailly

Please sign in to comment.