better cookie tests

mojolicious · Dec 28, 2011 · 5bff053 · 5bff053
1 parent 5f9728a
commit 5bff053
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/t/mojo/request.t b/t/mojo/request.t
@@ -1591,10 +1591,10 @@ is $req2->headers->cookie, 'foo=bar; bar=baz; baz=yada',
   'right "Cookie" value';
 is $req2->url, '/foo/bar', 'right URL';
 is $req2->url->to_abs, 'http://127.0.0.1/foo/bar', 'right absolute URL';
-is defined $req2->cookie('foo'),  1,  'right value';
-is defined $req2->cookie('bar'),  1,  'right value';
-is defined $req2->cookie('baz'),  1,  'right value';
-is defined $req2->cookie('yada'), '', 'no value';
+ok defined $req2->cookie('foo'),   'cookie "foo" exists';
+ok defined $req2->cookie('bar'),   'cookie "bar" exists';
+ok defined $req2->cookie('baz'),   'cookie "baz" exists';
+ok !defined $req2->cookie('yada'), 'cookie "yada" does not exist';
 is $req2->cookie('foo')->value, 'bar',  'right value';
 is $req2->cookie('bar')->value, 'baz',  'right value';
 is $req2->cookie('baz')->value, 'yada', 'right value';

diff --git a/t/mojo/response.t b/t/mojo/response.t
@@ -1,6 +1,6 @@
 use Mojo::Base -strict;
 
-use Test::More tests => 268;
+use Test::More tests => 269;
 
 # "Quick Smithers. Bring the mind eraser device!
 #  You mean the revolver, sir?
@@ -462,15 +462,16 @@ is $res2->version,     '1.1', 'right version';
 ok $res->at_least_version('1.0'), 'at least version 1.0';
 ok !$res->at_least_version('1.2'), 'not version 1.2';
 is $res2->headers->content_length, 0, 'right "Content-Length" value';
-is defined $res2->cookie('foo'), 1, 'right value';
-is defined $res2->cookie('baz'), 1, 'right value';
-is defined $res2->cookie('bar'), 1, 'right value';
+ok defined $res2->cookie('foo'),   'cookie "foo" exists';
+ok defined $res2->cookie('bar'),   'cookie "bar" exists';
+ok defined $res2->cookie('baz'),   'cookie "baz" exists';
+ok !defined $res2->cookie('yada'), 'cookie "yada" does not exist';
 is $res2->cookie('foo')->path,  '/foobar',  'right path';
 is $res2->cookie('foo')->value, 'bar',      'right value';
-is $res2->cookie('baz')->path,  '/foobar',  'right path';
-is $res2->cookie('baz')->value, 'yada',     'right value';
 is $res2->cookie('bar')->path,  '/test/23', 'right path';
 is $res2->cookie('bar')->value, 'baz',      'right value';
+is $res2->cookie('baz')->path,  '/foobar',  'right path';
+is $res2->cookie('baz')->value, 'yada',     'right value';
 
 # Build response with callback (make sure it's called)
 $res = Mojo::Message::Response->new;