TRUNK-3623 #371
Closed
TRUNK-3623 #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (StringUtils.isEmpty(serializedValue)) | ||
| return null; | ||
| return Context.getProviderService().getProviderByUuid(serializedValue); | ||
| } |
There was a problem hiding this comment.
I think it would nice to implement getTextSummary to return the provider's name, actually am starting to think we can do things more generically and reduce the amount of code to write for this ticket and related ones, i will add a comment to the root ticket to explain my view
| public Provider getValue(org.openmrs.customdatatype.datatype.ProviderDatatype datatype, HttpServletRequest request, | ||
| String formFieldName) throws InvalidCustomValueException { | ||
| String result = request.getParameter(formFieldName); | ||
| if (StringUtils.isBlank(result)) |
There was a problem hiding this comment.
After getting the request param the rest of the code should delegate to datatype.deserialize
|
Closing because author abandoned it. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
…ixes (openmrs#371) * Added :contains to the name parameter in the FHIR Location API * Fixed the loading issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for [TRUNK-3623] Create a custom data type and its associated handler for providers