fixed small MIME::Base64 and MIME::QuotedPrint related bugs in Mojo::…

…Util
mojolicious · Feb 7, 2012 · bf9a4fa · bf9a4fa
1 parent d495713
commit bf9a4fa
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,8 +1,10 @@
 This file documents the revision history for Perl extension Mojolicious.
 
-2.48    2012-02-07 00:00:00
+2.48    2012-02-08 00:00:00
         - Improved documentation.
         - Improved tests.
+        - Fixed small MIME::Base64 and MIME::QuotedPrint related bugs in
+          Mojo::Util.
 
 2.47    2012-02-06 00:00:00
         - Deprecated Hypnotoad configuration files in favor of more powerful

diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -295,9 +295,9 @@ push @EXPORT_OK, qw/punycode_encode qp_decode qp_encode quote/;
 push @EXPORT_OK, qw/secure_compare sha1_bytes sha1_sum trim unquote/;
 push @EXPORT_OK, qw/url_escape url_unescape xml_escape/;
 
-sub b64_decode { MIME::Base64::decode_base64(@_) }
+sub b64_decode { MIME::Base64::decode_base64(shift) }
 
-sub b64_encode { MIME::Base64::encode_base64(@_) }
+sub b64_encode { MIME::Base64::encode_base64(shift, shift) }
 
 sub camelize {
   my $string = shift;
@@ -545,9 +545,9 @@ sub punycode_encode {
   return $output;
 }
 
-sub qp_decode { MIME::QuotedPrint::decode_qp(@_) }
+sub qp_decode { MIME::QuotedPrint::decode_qp(shift) }
 
-sub qp_encode { MIME::QuotedPrint::encode_qp(@_) }
+sub qp_encode { MIME::QuotedPrint::encode_qp(shift) }
 
 sub quote {
   my $string = shift;

diff --git a/t/mojo/bytestream.t b/t/mojo/bytestream.t
@@ -7,6 +7,10 @@ use utf8;
 #  Yes. *lie dectector blows up*"
 use Test::More tests => 141;
 
+# Need to be loaded first to trigger edge case
+use MIME::Base64;
+use MIME::QuotedPrint;
+
 use_ok 'Mojo::Util',       'md5_bytes';
 use_ok 'Mojo::ByteStream', 'b';