make process.kill a no-op on windows

nodejs · Oct 21, 2011 · 69b73f9 · 69b73f9
1 parent fafb584
commit 69b73f9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 13 deletions.
diff --git a/src/node.js b/src/node.js
@@ -321,24 +321,34 @@
   };
 
   startup.processKillAndExit = function() {
+    var isWindows = process.platform === 'win32';
+
     process.exit = function(code) {
       process.emit('exit', code || 0);
       process.reallyExit(code || 0);
     };
 
-    process.kill = function(pid, sig) {
-      // preserve null signal
-      if (0 === sig) {
-        process._kill(pid, 0);
-      } else {
-        sig = sig || 'SIGTERM';
-        if (startup.lazyConstants()[sig]) {
-          process._kill(pid, startup.lazyConstants()[sig]);
+    if (isWindows) {
+      process.kill = function(pid, sig) {
+        console.warn('process.kill() is not supported on Windows.  Use ' +
+                     'child.kill() to kill a process that was started '  +
+                     'with child_process.spawn().');
+      }
+    } else {
+      process.kill = function(pid, sig) {
+        // preserve null signal
+        if (0 === sig) {
+          process._kill(pid, 0);
         } else {
-          throw new Error('Unknown signal: ' + sig);
+          sig = sig || 'SIGTERM';
+          if (startup.lazyConstants()[sig]) {
+            process._kill(pid, startup.lazyConstants()[sig]);
+          } else {
+            throw new Error('Unknown signal: ' + sig);
+          }
         }
-      }
-    };
+      };
+    }
   };
 
   startup.processSignalHandlers = function() {

diff --git a/test/simple/test-process-kill-null.js b/test/simple/test-process-kill-null.js
@@ -19,8 +19,10 @@
 // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-// libuv-broken
-
+if (process.platform === 'win32') {
+  console.warn('Skipping because process.kill is not supported on windows');
+  process.exit(0);
+}
 
 
 var assert = require('assert');