Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display controller. #569

Merged
merged 1 commit into from Jun 21, 2013
Merged

Display controller. #569

merged 1 commit into from Jun 21, 2013

Conversation

norv
Copy link
Contributor

@norv norv commented Jun 21, 2013

Bit of standarization, add action_index() to Display controller.
(quick PR cuz Ema intends to try extending the class, lets have it with the interface it should have)

norv added a commit that referenced this pull request Jun 21, 2013
@norv norv merged commit 4d29a16 into elkarte:master Jun 21, 2013
@emanuele45
Copy link
Contributor

Slightly related: what do you think if action_quickmod2 goes somewhere else? For example ModerationCenter_Controller.

I was playing with Display_Controller (splitting a bit action_index in more functions) and it sounds strange to have a quickmod there...

@norv
Copy link
Contributor Author

norv commented Jun 21, 2013

Oh, interesting question, because it appears somehow this way. But, no, I don't think mod center has anything to do, because the request doesn't happen in/from moderation center pages, does it?

For what the user can do in display or message index pages, IMO first choice would be: display or message index controllers should have actions, to handle those requests. So, yes, quickmod() and quickmod2().
If you feel it's too much for them, then a separate moderation controller: but for moderation actions, not some controller which is displaying mod center pages.

(side note: badly named as 2, cuz they have no relation with each other, but they were functions so I guess conflicts were the reason; they'd both be quickmod)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants