explain new behavior

mojolicious · May 12, 2014 · b125143 · b125143
1 parent 79396d7
commit b125143
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 15 deletions.
diff --git a/lib/Mojo/JSON.pm b/lib/Mojo/JSON.pm
@@ -263,14 +263,11 @@ sub _encode_value {
   return 'null' unless defined $value;
 
   # Number
-  {
-    no warnings 'numeric';
-    my $num = $value;
-    $num += 0;
-    my $flags = B::svref_2object(\$value)->FLAGS;
-    return $num
-      if $flags & (B::SVp_IOK | B::SVp_NOK) && $num eq $value && $num * 0 == 0;
-  }
+  my $num = $value;
+  { no warnings 'numeric'; $num += 0 }
+  my $flags = B::svref_2object(\$value)->FLAGS;
+  return $num
+    if $flags & (B::SVp_IOK | B::SVp_NOK) && $num eq $value && $num * 0 == 0;
 
   # String
   return _encode_string($value);
@@ -327,9 +324,8 @@ It supports normal Perl data types like scalar, array reference, hash
 reference and will try to call the C<TO_JSON> method on blessed references, or
 stringify them if it doesn't exist. Differentiating between strings and
 numbers in Perl is hard, depending on how it has been used, a scalar can be
-both at the same time. Since numeric comparisons on strings are very unlikely
-to happen intentionally, the numeric value always gets priority, so any
-scalar that has been used in numeric context is considered a number.
+both at the same time. The string value always gets precedence unless both
+representations are equivalent.
 
   [1, -2, 3]     -> [1, -2, 3]
   {"foo": "bar"} -> {foo => 'bar'}

diff --git a/t/mojo/json.t b/t/mojo/json.t
@@ -295,10 +295,7 @@ is encode_json({test => [$num, $str]}), '{"test":[1,"0 but true"]}',
 
 # Upgraded string
 $str = "bar";
-{
-  no warnings 'numeric';
-  $num = 23 + $str;
-}
+{ no warnings 'numeric'; $num = 23 + $str }
 is encode_json({test => [$num, $str]}), '{"test":[23,"bar"]}',
   'upgraded string detected';